STACKITLB-1837 | add ALB certificates to provider#1296
Open
david-mey-STACKIT wants to merge 17 commits intostackitcloud:mainfrom
Open
STACKITLB-1837 | add ALB certificates to provider#1296david-mey-STACKIT wants to merge 17 commits intostackitcloud:mainfrom
david-mey-STACKIT wants to merge 17 commits intostackitcloud:mainfrom
Conversation
Co-authored-by: Marcel Jacek <72880145+marceljk@users.noreply.github.com>
david-mey-STACKIT
force-pushed
the
main
branch
4 times, most recently
from
289b525 to
f74a895
Compare
|
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
marceljk
reviewed
Mar 31, 2026
|
|
||
| subject { | ||
| common_name = "localhost" | ||
| organization = "Stackit Test" |
Contributor
There was a problem hiding this comment.
Suggested change
| organization = "Stackit Test" | |
| organization = "STACKIT Test" |
| func (r *certDataSource) Schema(_ context.Context, _ datasource.SchemaRequest, resp *datasource.SchemaResponse) { | ||
| descriptions := map[string]string{ | ||
| "main": "Certificates resource schema.", | ||
| "id": "Terraform's internal resource ID. It is structured as `project_id`,`region`,`name`.", |
Contributor
There was a problem hiding this comment.
Suggested change
| "id": "Terraform's internal resource ID. It is structured as `project_id`,`region`,`name`.", | |
| "id": "Terraform's internal resource ID. It is structured as `project_id`,`region`,`cert_id`.", |
The id should always contain the attributes, which a required to call the GET endpoint.
| "id": "Terraform's internal resource ID. It is structured as `project_id`,`region`,`name`.", | ||
| "project_id": "STACKIT project ID to which the certificate is associated.", | ||
| "region": "The resource region (e.g. eu01). If not defined, the provider region is used.", | ||
| "cert-id": "The ID of the certificate.", |
Contributor
There was a problem hiding this comment.
keep the map keys consistent in snake case, like the attributes itself
Suggested change
| "cert-id": "The ID of the certificate.", | |
| "cert_id": "The ID of the certificate.", |
| Computed: true, | ||
| }, | ||
| "cert_id": schema.StringAttribute{ | ||
| Description: descriptions["cert-id"], |
Contributor
There was a problem hiding this comment.
Suggested change
| Description: descriptions["cert-id"], | |
| Description: descriptions["cert_id"], |
| Computed: true, | ||
| PlanModifiers: []planmodifier.String{ | ||
| stringplanmodifier.RequiresReplace(), | ||
| stringplanmodifier.UseStateForUnknown(), |
Contributor
There was a problem hiding this comment.
UseStateForUnknown is not needed here and can potentially cause some issues, so it should be removed
Suggested change
| stringplanmodifier.UseStateForUnknown(), |
| ConfigVariables: testConfigVarsMax, | ||
| Config: testutil.CertProviderConfig() + resourceMaxConfig, | ||
| Check: resource.ComposeAggregateTestCheckFunc( | ||
| // Load balancer instance resource |
Comment on lines
+150
to
+151
| resource.TestCheckResourceAttrSet("stackit_alb_certificate.certificate", "public_key"), | ||
| resource.TestCheckResourceAttrSet("stackit_alb_certificate.certificate", "private_key"), |
Contributor
There was a problem hiding this comment.
you can do here the same check mentioned above
|
|
||
| "github.com/hashicorp/terraform-plugin-framework/diag" | ||
| "github.com/stackitcloud/stackit-sdk-go/core/config" | ||
| certSdk "github.com/stackitcloud/stackit-sdk-go/services/certificates" |
Contributor
There was a problem hiding this comment.
Suggested change
| certSdk "github.com/stackitcloud/stackit-sdk-go/services/certificates" | |
| certSdk "github.com/stackitcloud/stackit-sdk-go/services/certificates/v2api" |
| } | ||
| return fmt.Sprintf(` | ||
| provider "stackit" { | ||
| cart_custom_endpoint = "%s" |
Contributor
There was a problem hiding this comment.
Suggested change
| cart_custom_endpoint = "%s" | |
| alb_certificates_custom_endpoint = "%s" |
Comment on lines
+19
to
+21
| if providerData.ALBCustomEndpoint != "" { | ||
| apiClientConfigOptions = append(apiClientConfigOptions, config.WithEndpoint(providerData.ALBCustomEndpoint)) | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| if providerData.ALBCustomEndpoint != "" { | |
| apiClientConfigOptions = append(apiClientConfigOptions, config.WithEndpoint(providerData.ALBCustomEndpoint)) | |
| } | |
| if providerData.ALBCertificatesCustomEndpoint != "" { | |
| apiClientConfigOptions = append(apiClientConfigOptions, config.WithEndpoint(providerData.ALBCertificatesCustomEndpoint)) | |
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
STACKITLB-1837
Add ALB TLS certificates provider (API: https://docs.api.stackit.cloud/documentation/certificates/version/v2)
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)